Submitted by lowerthanred
Current behavior: When tux shoots a ranged weapon with a high ROF (rate of fire), the entire attack animation (point gun, shoot gun, return to standing position) is played repeatedly and greatly sped up. Looks weird. Good example: Laser pulse rifle.

Expected/wanted behavior: When tux shoots such a weapon, the few frames in which the gun is actually shot, say frames 5-8, should loop or 'ping-pong' (played normally, then backwards, then normally again, then...)

Possibly this can be applied to any weapon with a Recharge time smaller than some value defined in item_archtypes.

Posted by ahuillet
Fluzz, would you be interested and willing to do this?

I think this should get fixed until next release.
Assigning to fluzz :p

Yes, taking it !

Infrared, in your initial comment, you said:

----------
Current behavior: When tux shoots a ranged weapon with a high ROF (rate 
of fire), the entire attack animation (point gun, shoot gun, return to 
standing position) is played repeatedly and greatly sped up. Looks 
weird. Good example: Laser pulse rifle.

Expected/wanted behavior: When tux shoots such a weapon, the few frames 
in which the gun is actually shot, say frames 5-8, should loop or 
'ping-pong' (played normally, then backwards, then normally again, then...)

Possibly this can be applied to any weapon with a Recharge time smaller 
than some value defined in item_archtypes.
----------

I'm starting working on it, and would like to have some more precisions.

So I will add a shoot_first_keyframe and shoot_last_keyframe to Tux
animation definition.

I will also add a loop_shoot_animation_rate in the Tux rendering config.
If a weapon RoF is higher, the shoot animation will be played in a loop,
as you want (if think that there is the same kind of issue with the
knife, iirc).

But what about the Recharge Time ? I do not really understand how it is
related....

(And please, register to the new bug tracker: bugs.freedroid.org)

Sorry, registered now. :)

I think I may have confused the recharge time (the time it takes the weapon to
reload, as in change magazine/round) and rate of fire (the number of consecutive
shots the weapon can fire in, say, a second). Recharge time is indeed irrelevant
to the issue, RoF is what matters. Thanks for taking care of this. :)

We use two different notions with a touchy wording.

"recharge time" is the time between two shots (ie. 1/RoF)
"reload time" is the time to change the magazine

So you are actually interested in recharge time. :)

First testing implementation available: http://rb.freedroid.org/r/1398/

This implementation requires ACK from infrared and matthias on a functional
point of view. Once this is done fluzz and I can refine it to match our
technical expectations.

As per the discussion e-mail, not a requirement for 0.15, but it would be nice
to have done.

See:
http://sourceforge.net/mailarchive/forum.php?thread_name=20111031082947.464f9440%40freedroid.org&forum_name=freedroid-discussion

Not a bug...