Issue859

Title UB when creating 100 levels
Priority bug Status open
Assigned To Keywords editor
Linked issues Watchers

Submitted on 2016-08-11 07h57 by matthiaskrgr, last changed by matthiaskrgr.

Messages
Author: matthiaskrgr Date: 2016-08-11   07h57
There's some UB when creating and loading the level 99:

view.c:749:2: runtime error: index 100 out of bounds for type 'level *[100]'
    #0 0x69dd6e in gps_transform_map_init
/home/matthias/vcs/copy_of_git/freedroid/src/view.c:749:2
    #1 0x6ef376 in add_rem_level
/home/matthias/vcs/copy_of_git/freedroid/src/lvledit/lvledit_menu.c:441:5
    #2 0x6ef376 in level_options
/home/matthias/vcs/copy_of_git/freedroid/src/lvledit/lvledit_menu.c:772
    #3 0x6ebab9 in do_level_editor_main_menu
/home/matthias/vcs/copy_of_git/freedroid/src/lvledit/lvledit_menu.c:989:4
    #4 0x6e607d in leveleditor_process_input
/home/matthias/vcs/copy_of_git/freedroid/src/lvledit/lvledit_input.c:193:23
    #5 0x6ca2c4 in LevelEditor
/home/matthias/vcs/copy_of_git/freedroid/src/lvledit/lvledit.c:279:3
    #6 0x609d02 in main /home/matthias/vcs/copy_of_git/freedroid/src/main.c:183:4
    #7 0x7f7b30719730 in __libc_start_main (/lib64/libc.so.6+0x20730)
    #8 0x42f828 in _start
(/home/matthias/vcs/copy_of_git/freedroid/src/freedroidRPG+0x42f828)

SUMMARY: AddressSanitizer: undefined-behavior view.c:749:2 in 
map.c:1243:2: runtime error: index 100 out of bounds for type 'level *[100]'
    #0 0x6126eb in free_current_ship
/home/matthias/vcs/copy_of_git/freedroid/src/map.c:1243:2
    #1 0x6128c9 in LoadShip
/home/matthias/vcs/copy_of_git/freedroid/src/map.c:1263:2
    #2 0x5b65f5 in prepare_level_editor
/home/matthias/vcs/copy_of_git/freedroid/src/init.c:592:2
    #3 0x62b5d0 in Startup_handle
/home/matthias/vcs/copy_of_git/freedroid/src/menu.c:810:3
    #4 0x631519 in RunSubMenu
/home/matthias/vcs/copy_of_git/freedroid/src/menu.c:747:13
    #5 0x630707 in RunMenu /home/matthias/vcs/copy_of_git/freedroid/src/menu.c:776:2
    #6 0x630707 in StartupMenu
/home/matthias/vcs/copy_of_git/freedroid/src/menu.c:782
    #7 0x609cd8 in main /home/matthias/vcs/copy_of_git/freedroid/src/main.c:173:4
    #8 0x7f7b30719730 in __libc_start_main (/lib64/libc.so.6+0x20730)
    #9 0x42f828 in _start
(/home/matthias/vcs/copy_of_git/freedroid/src/freedroidRPG+0x42f828)

SUMMARY: AddressSanitizer: undefined-behavior map.c:1243:2 in 
map.c:74:15: runtime error: variable length array bound evaluates to
non-positive value 0
    #0 0x60f4aa in respawn_level
/home/matthias/vcs/copy_of_git/freedroid/src/map.c:74:2
    #1 0x62029d in GetThisLevelsDroids
/home/matthias/vcs/copy_of_git/freedroid/src/map.c:1989:2
    #2 0x61fab7 in GetCrew /home/matthias/vcs/copy_of_git/freedroid/src/map.c:1841:3
    #3 0x5b6200 in PrepareStartOfNewCharacter
/home/matthias/vcs/copy_of_git/freedroid/src/init.c:549:2
    #4 0x5b65ff in prepare_level_editor
/home/matthias/vcs/copy_of_git/freedroid/src/init.c:593:2
    #5 0x62b5d0 in Startup_handle
/home/matthias/vcs/copy_of_git/freedroid/src/menu.c:810:3
    #6 0x631519 in RunSubMenu
/home/matthias/vcs/copy_of_git/freedroid/src/menu.c:747:13
    #7 0x630707 in RunMenu /home/matthias/vcs/copy_of_git/freedroid/src/menu.c:776:2
    #8 0x630707 in StartupMenu
/home/matthias/vcs/copy_of_git/freedroid/src/menu.c:782
    #9 0x609cd8 in main /home/matthias/vcs/copy_of_git/freedroid/src/main.c:173:4
    #10 0x7f7b30719730 in __libc_start_main (/lib64/libc.so.6+0x20730)
    #11 0x42f828 in _start
(/home/matthias/vcs/copy_of_git/freedroid/src/freedroidRPG+0x42f828)

SUMMARY: AddressSanitizer: undefined-behavior map.c:74:15 in 


@ e6c28a78fb5e786fb5e4211a30983b529a459974
History
Date User Action Args
2016-08-11 07:57:58matthiaskrgrcreate