Issue900

Title Appdata is ancient
Priority bug Status resolved
Assigned To Keywords
Linked issues Watchers

Submitted on 2017-10-18 10h59 by Snark, last changed by fluzz.

Files
File name Uploaded Type Edit Remove
30_appdata.patch Snark, 2017-10-18.11:22:38 text/x-patch
Messages
Author: Snark Date: 2017-10-18   10h59
freedroidrpg.appdata.xml is using a legacy version of the format and isn't 
installed in the correct directory anymore ; I'll try to provide a patch later.
Author: Snark Date: 2017-10-18   11h22
Here is the promised patch ; there is an appstreamcli tool to check if the file 
is valid, and it seems happy with the result.

Attached 30_appdata.patch.
Author: jesusalva Date: 2017-10-21   00h24
Thanks for the report and the work, we'll 
try to Ensure it is updated or at least 
reviewed by next week. =D

Due busy months it cannot be done in 
immediate.
Thanks 
Jesusalva
Author: jesusalva Date: 2017-10-31   02h04
This diff could not be applied.
aka. EOF expected, got '<content_rating>'

===========================================
patching file pkgs/freedesktop/freedroidrpg.appdata.xml
Hunk #2 FAILED at 39.
1 out of 2 hunks FAILED -- saving rejects to file
pkgs/freedesktop/freedroidrpg.appdata.xml.rej

Reason detected to be missing and conflicting content_rating on diff file.
Check the last line of the diff.

==================================================
Also, about providing a "proper" patch, check
http://www.freedroid.org/dev-section/review-board/

It is much easier and faster to accept patches via Review Board (for example,
using RB and the instructions on that page, I could have returned to you 'by
next week'...)
Of course, if for some reason you are unable to make use of Review Board, please
let us know.

Also, for a definitive Ship It, you will need to wait for Fluzz, whom shall be
available before New Year.
I can only do checks to ensure that his work is the fastest possible (looking at
code >> make >> playtest/benchmark/does-it-run-on-my-PC >> commit)

Thanks for your work,
Jesusalva
Game Content
Author: fluzz Date: 2018-03-08   14h36
Fixed in commit 1b018d493
History
Date User Action Args
2018-03-08 14:36:24fluzzsetstatus: open -> resolved
messages: + msg3548
2017-10-31 02:04:30jesusalvasetmessages: + msg3499
2017-10-21 00:24:38jesusalvasetmessages: + msg3492
2017-10-18 11:22:38Snarksetfiles: + 30_appdata.patch
messages: + msg3491
2017-10-18 10:59:57Snarkcreate