Submitted by matthiaskrgr
If the SADD is hacked and one clicks the   Nr=13 Text=_"Yes, you can get to the surface. But the guns are still on."
      text option, the game crashes:

----------------------------------------------------------------------
Freedroid has encountered a problem:
In function: get_enemy_with_dialog.
FreedroidRPG package and version number: freedroidrpg 0.14.1+svn.
Could not find a droid corresponding to the dialog "SADD".

If you encounter this message, please inform the Freedroid developers
about the problem, by either

  sending e-mail to:
    freedroid-discussion AT lists.sourceforge.net
  mention it to someone of the developers on our IRC channel:
    channel: #freedroid on irc.freenode.net
  post on our forum at:
    https://sourceforge.net/apps/phpbb/freedroid
  report a bug on our tracker at:
    https://sourceforge.net/tracker/?group_id=54521&atid=474016

Thanks a lot!

Freedroid will terminate now to draw attention to the problems it could
not resolve.  Sorry if that interrupts a major game of yours...

----------------------------------------------------------------------


I assume that the problem is that SADD uses the Takeover  dialog when it's hacked, so

set_npc_faction("crazy", "SADD")
set_bot_name(_"SADD -- Exterminate Mode", "SADD")

cannot be executed any more.
(why is   hide(13) show(40, 41) -- show(15)
  show(15) commented out btw. and not removed?)

Additionally, I think it should be possible to open the gates SADD has control to an disable the guns if SADD is hacked, maybe SADDs hacking skill should be improved in order to balance this, if it gets implemented.

Bug found by Zombie.

revision 3490
should affect 0.14.1 :-/

Posted by salimiles
I think you have diagnosed the problem correctly. The good news is, because we don't have many droids with unique dialogs who we try to change or access aspects of after they possibly become hostile (and therefore turn-able). I think currently we only have the one: SADD.

- - - - -

The reason for the show(15) being commented out, is the thread of dialog leading through the Tania's Sanitary mission (where you break through walls to turn off the autoguns). Instead we skip ahead to the escort mission nodes (starts at 40 & 41).

At some point in the past the old Tania's Sanitary mission was broken.  By 0.14 it was possible to do all aspects of the mission, although probably not without cheating, hence it wasn't included as a "mission" in 0.14 .

Why it wasn't included: 
1) lack of explanation about breaking though walls in the Tutorial (need something like http://rb.freedroid.org/r/541/ )
2) not well integrated with the new Tania's Exit mission (I think they should all be under the same quest-log and mission name).
3) possibly still too difficult to complete, needs balance

Posted by salimiles
Cop out solution would be to make the SADD human & not hackable...

Posted by salimiles
A patch is at http://rb.freedroid.org/r/851/ (currently on hold?)

Posted by ahuillet
Ok, this needs a fix or a revert. Matthias, you've got authority to revert the patch that breaks the game if no other solution can be found. 

Posted by matthiaskrgr
Please not  http://rb.freedroid.org/r/851/


One solution is to make SADD human to simply avoid hacking.

Perhaps we can have a third 'race' like bots-nonhackable which cannot be hacked (like humans) but spill oil and not blood (like bots)?

This is a bug that crashes the game? Marking as important.

I still think making SADD human is still the easiest option. I'll have a look at
this.

This very issue seems to be fixed, but when I hacked the SADD and accessed
control terminal, the game crashed.


----------------------------------------------------------------------
Freedroid has encountered a problem:
In function: get_enemy_with_dialog.
FreedroidRPG package and version number: freedroidrpg 0.14.1+svn.
Could not find a droid corresponding to the dialog "SADD".

If you encounter this message, please inform the Freedroid developers
about the problem, by either

  sending e-mail to:
    freedroid-discussion AT lists.sourceforge.net
  mention it to someone of the developers on our IRC channel:
    channel: #freedroid on irc.freenode.net
  post on our forum at:
    https://sourceforge.net/apps/phpbb/freedroid
  report a bug on our tracker at:
    https://sourceforge.net/tracker/?group_id=54521&atid=474016

Thanks a lot!

Freedroid will terminate now to draw attention to the problems it could
not resolve.  Sorry if that interrupts a major game of yours...



I'll make SADD human so we cannot hack it any more.

Patch at Review Request 1355

I don't like your patch much as I think there is an actual issue underneath this
ticket that needs to be fixed.

What's the control terminal? Does it use the same dialog as SADD?

From SACD.dialog:

Nr=3 Text=_"/usr/bin/hermodoors --open"
<LuaCode>
	npc_says(_"Opening doors...")
	npc_says(_"Connecting to peripheral controller...")
	change_obstacle_state("SACD-North-1", "opened")
	change_obstacle_state("SACD-North-2", "opened")
	change_obstacle_state("SACD-North-3", "opened")
	change_obstacle_state("SA-Main-EastN", "opened")
	change_obstacle_state("SA-Main-EastS", "opened")
	change_obstacle_state("SA-Main-WestN", "opened")
	change_obstacle_state("SA-Main-WestS", "opened")
	change_obstacle_state("SA-Main-Enter", "opened")
	npc_says(_"ERROR: An error occured while opening some doors.")
	npc_says(_"Please enter unlock security override password:")
	tux_says(_"CTRL+C")
	npc_says(_"Invalid password. Entering lockdown mode.")
	npc_says(_"ERROR: Lockdown mode has an error.", "NO_WAIT")
	npc_says(_"ERROR: error has an error.", "NO_WAIT")
	npc_says(_"ERROR: SADD droids now set to search-and-destroy mode.")
	set_npc_faction("ms", "SADD")
	set_bot_name(_"SADD -- Exterminate Mode", "SADD")
	set_bot_destination("SADD-MoveTarget", "SADD")
	cli_says(_"admin@sadefence: ~ #", "NO_WAIT")
	hide(3)
</LuaCode>

Fixed in r4942. Thanks !