Submitted by curtmack
Tested on Windows 7 64-bit, might be Windows-only.

When editing or creating a map label in the editor, you cannot use shifted characters that are not capital letters; instead, the game types the unshifted equivalent. Additionally, the keypad /*-+ characters do not work; they simply don't print anything.

Posted by npepinpe
I can confirm this bug on Mac OSX 10.6.7 with revision 4388; I'll check it out now.

Posted by npepinpe
Put up a partial fix for /*-+. characters: http://rb.freedroid.org/r/1046/
I will work on the rest later, unless someone wants to take it up.

Posted by curtmack
I've been able to fix it by making getchar_raw return the unicode component of the SDL key event if that component exists, but I'm not sure if that breaks anything else.

Posted by npepinpe
Yeah, we should probably support Unicode if we ever want people to use characters like \u00e0, \u00fc and such.

Posted by hakzsam
Not a bug.

It's a limitation of toupper (see the manpage)
"If c is not an unsigned char value, or EOF, the behavior of these functions is undefined."

For the /*-+ symbols, I'm not sure that is really needed.

Posted by hakzsam
And the details of what constitutes an uppercase or lowercase letter depend on the current locale.

Posted by curtmack
But SDL can parse all of that for us. See the documentation for SDL_EnableUnicode and SDL_keysym. toupper shouldn't be needed in this case.

Posted by npepinpe
Perhaps when we are expecting textual input (i.e.: labels) it would be good to use SDL's internal text input functions. More info -> http://wiki.libsdl.org/moin.cgi/Tutorials/TextInput

Seems like it would save us a lot of work.

Posted by curtmack
It doesn't look like there's an easy way to force SDL to start with default text, which is required by the current solution. I think the Unicode solution will be easier to work into the rest of the code.

Posted by ahuillet
The TextInput routines are as far as I know part of SDL 1.3 so this isn't an option.

As for Unicode - please avoid it.

Posted by curtmack
This solution wouldn't actually use Unicode. It would get information from SDL in Unicode because that's the form SDL provides it in, but any values outside the ASCII range would be ignored.

This looks linked to issue 234. Also rb1046 was submitted. Do either of these
issues still occur?

http://rb.freedroid.org/r/2362/ actually promises to fix this bug.
Must be playtest on win32, though.

Fixed in commit 6423bb39f