Issue605

Title Leaving Map Editor exits application
Priority minor Status open
Assigned To Keywords
Linked issues Watchers

Submitted on 2012-08-07 23h56 by gorgonz, last changed by matthiaskrgr.

Files
File name Uploaded Type Edit Remove
freedroid-console-output gorgonz, 2012-08-07.23:56:35 application/octet-stream
Messages
Author: gorgonz Date: 2012-08-07   23h56
copmiled it myself (OSS12.1 64bit)

After starting it I wanted to look around and selected the level editor first.
Map was shown and i just looked around a little, then exited the editor with the
wrong button "test map". I thought the icon means "leaving unsaved".

The application did not return to the menu but exited. Since i started from
console, i will add an attachment with the content of it.

Since a second try didn't show up the same bug, i call it minor. you have the
coordinates from output. maybe tux got out of control ;-), where you didn't
expect it.
Author: matthiaskrgr Date: 2012-08-08   00h13
Hey,  thanks for the detailed description. :-)

I from the output, it looks like you just walked out of a level (thus the
negative coordinates of the y-axis). This likely to happen when playing around
with the level editor, I experienced it already a lot myself. :)
I guess that while looking around, you scrolled to the edge of the map and then
playtested it; walked out of the map.
Author: salimiles Date: 2012-09-18   23h06
I think this could be easily resolved by having a check that does the following
for both the x and y coordinates before playtesting:

For locations <0, assigns a location of 0.
For locations >level_size, assigns a location of level_size

This sort of error should not cause a game crash.
Author: hakzsam Date: 2012-09-19   18h45
This is not a crash! It's just a fatal error which exits the application.
I agree with the idea sent by salimiles.
Author: fluzz Date: 2013-10-08   14h37
On 08/08/2012 02:13 AM, Matthias Krüger - Roundup wrote:
>
> Matthias Krüger <matthias.krueger@famsik.de> added the comment:
>
> Hey,  thanks for the detailed description. :-)
>
> I from the output, it looks like you just walked out of a level (thus the
> negative coordinates of the y-axis). This likely to happen when playing around
> with the level editor, I experienced it already a lot myself. :)
> I guess that while looking around, you scrolled to the edge of the map and then
> playtested it; walked out of the map.
>

I also guess so.
The Level Editor being a dev tool, I do not think that we should take 
care of such an issue.
What do you think, Matthias ?
Author: matthiaskrgr Date: 2013-10-08   21h37
Well it's accessible by the menu publicly so it is supposed to work properly at
some point I think... :)

However I already wondered why not prevent the move_mouse_target from being set
on "void" and just printing (stderr) a warning that we tried to do so (instead
of crashing).
History
Date User Action Args
2013-10-08 21:37:54matthiaskrgrsetmessages: + msg2609
2013-10-08 14:37:03fluzzsetmessages: + msg2601
2012-09-19 18:45:57hakzsamsetmessages: + msg2344
2012-09-18 23:06:26salimilessetmessages: + msg2341
2012-08-08 00:13:19matthiaskrgrsetmessages: + msg2325
2012-08-07 23:56:35gorgonzcreate