Title Kill Faction contains Respawn Bug
Priority important Status open
Assigned To fluzz Keywords
Linked issues Watchers fluzz, infrared

Submitted on 2018-01-26 06h14 by jesusalva, last changed by fluzz.

Author: jesusalva Date: 2018-01-26   06h14
At lua.c:873 we only check alive bots to change will_respawn flag.

This means any bot killed prior to calling kill_faction with no_respawn flag
WILL still respawn, as they're not in that list.

A possible solution is handling will_respawn flag later, against all bots, not
just the ones alive.

Global Storyline allows this bug because Dark Robot Circle actions, but that
still wasn't introduced to the player, resulting in a weird bug.
Author: jesusalva Date: 2018-01-26   20h39
Also noteworthy: Friendly bots, at respawn time, will be turned rogue.

This probably should not be an issue if level 59 have a no-respawn flag, but 
may still happen.

Fixing this extra complexity is not release blocker, but above problem may be.
Author: fluzz Date: 2018-03-26   17h27
That's an other issue.
So, please fill an other ticket.
Author: fluzz Date: 2018-03-26   17h47
See RR2376, for a fix for the first reported issue.
Author: fluzz Date: 2018-03-26   17h56
About the second issue, what kind of 'friendly respawned bot' become hostile ?
In the code, as far as I can see, only the faction of the taken-over bots
faction is reset. Is that your issue ?
But, eh, open an other ticket, please...
Author: fluzz Date: 2018-03-27   16h31
First part fixed in commit c9e2a358a
Date User Action Args
2018-03-27 16:31:33fluzzsetmessages: + msg3559
2018-03-26 17:56:41fluzzsetmessages: + msg3557
2018-03-26 17:47:07fluzzsetassignedto: fluzz
messages: + msg3556
nosy: + fluzz
2018-03-26 17:27:35fluzzsetmessages: + msg3555
2018-01-26 20:39:03jesusalvasetmessages: + msg3541
2018-01-26 06:14:32jesusalvacreate