Title Game crashes when attempting to teleport at dead NPC
Priority important Status resolved
Assigned To fluzz Keywords
Linked issues Watchers fluzz, jesusalva

Submitted on 2018-10-21 21h27 by temporary, last changed by fluzz.

Author: temporary Date: 2018-10-21   21h27
Game crashes if any NPC who must teleport after HF quest is dead.
Author: jesusalva Date: 2018-12-07   03h00
Fixed with a simple check. Teleport looks for NPC on alive list, but as they are

Note that Spencer death will still crash the game (Uh, it is a little worse than
just unwinnable apparently).

I think the game shouldn't crash when it looks to teleport a NPC and doesn't
finds it on alive list, but only on dead list. It should report the unhandled
exception, and perhaps even show a console message “attempted to teleport a dead
NPC” yadda yadda “game may be unwinnable or have broken storyline”.

That's why I'm assigning fluzz, moving priority, and renaming title to be more
clear. (And removing keywords)
Author: fluzz Date: 2019-04-18   16h19
Jesusalva, could you provide a backtrace of the crash, please ?

And what teleport function crashes, Npc:teleport("there") or
teleport_npc("there", "the_bot") ?
Author: jesusalva Date: 2019-04-19   01h15
1- Kill Spencer (use VMX Grenade)
2- Warp to map 59 with cheating (HFF)
3- Deploy faulty firmware upgrade
4- Ask for version.

Spencer talks normally, asks you to stand 

5- Leave dialog normally and standby.

> Game crashes.

(It crashed with other NPCs but I was not 
lazy and fixed those less important 
Author: fluzz Date: 2019-04-21   12h48
Patched pushed in commit 7a43ff815, that prevents to teleport a dead NPC,
informs the player about the bug, and avoids the teleportation.
But note that the actual fix would be to check if a npc is alive before to
teleport it, in lua scripts.
Date User Action Args
2019-04-21 12:48:39fluzzsetstatus: open -> resolved
messages: + msg3613
2019-04-19 01:15:43jesusalvasetmessages: + msg3611
2019-04-18 16:22:15fluzzsetnosy: + jesusalva
2019-04-18 16:19:27fluzzsetmessages: + msg3610
2018-12-07 03:00:29jesusalvasetkeyword: - quest
title: Game crashes if any NPC who is required is dead after HF quest teleport -> Game crashes when attempting to teleport at dead NPC
nosy: + fluzz
messages: + msg3605
priority: critical -> important
assignedto: fluzz
2018-10-21 21:27:06temporarycreate