Fluzz says that he only get one resolution (3360x1050) shown in the menu entry
on his work computer.

[...]
12:44 <+fluzz> hail, on my dual-headed work computer, I only get 1 entry in the
resolution list (3360x1050). Not 
               really useful !
[...]
12:45 <+fluzz> so it only displays supported full-screen resolution, I guess...
[...]

I hardly see any solution other than a revert of the patch to instead display a
predefined list of resolutions.

The list of supported resolutions is indeed only useful on full-screen
mode...

So, what could be done is to display a list combining some predefined
resolutions + the supported ones, and somehow 'mark' (specific color ?)
the supported ones, so that the player knows which one he can choose in
full-screen mode.

Now, there is still the problem of big lists. I would be in favor of
re-using the keychart code (display several columns)...

What exactly is the problem with big lists?

If I remember correctly, you can scroll up and down in the list using the ↓ and
↑ arrow keys.

That way you can access resolutions you couldn't click because they were 'beyond
the window boundary'.

No I can't, without applying the 'scrolling patch', with is not yet in,
iirc.

And moreover, there is no way for the user to know that the list is 
scrollable, through keyboard only (or perhaps I'm wrong) ?

Oh, I'm sorry.

Perhaps we could display some real up- and down-scrolling buttons in the menu?

Make sure you're running libsdl >= 1.2.14
http://www.libsdl.org/release/changes-1.2.html

SDL_GetVideoInfo() can only be as wrong as your X modelines, if you're using 
xinerama this is a well documented problem (with SDL).

this may be helpful:
http://forums.libsdl.org/viewtopic.php?t=7233

also, try setting SDL_VIDEO_FULLSCREEN_DISPLAY=0 and running

You do not get my point...
No matter if my xmodlines are right or wrong...
Not all users are playing fdrpg in fullscreen mode (I am not).
And in windowed mode, I do not want to be stuck to the list of supported
fullscreen modes. I want to use a 800x600 window, even if my video-card does not
support it as a fullscreen resolution (provided that my current screen
resolution is wider than 800x600, for sure...).

-r800x600

I see this requiring a new patch to fix a failure in the underlying system, but I 
don't think reversion of my old patch is a better answer. Especially since I'm 
here actively working on the project and able to maintain my patch.

^ command line switch, not a revision link

Bryan, I am not sure you fully understand fluzz (and I) objection.

The issue is that a user wants to be presented a list of resolutions to use. No
matter whether using windowed or fullscreen mode, you never want to manually
input your resolution. As a result, I understand the underlying motivation for
your original patch (which prompted me to accept it), but I don't think it fits
the functional requirement of a resolution menu.
It's not about maintenance, and a revert in this case has nothing to do with
your patch being well done or not - it's just that on a functional point of view
it turns out that what your patch does is perhaps not what we really want to do
with the resolution menu.
Your thoughts are more than welcome on the matter.

How about merging the old and new method? auto detect resolutions, append a list 
of hard-coded resolutions, prune duplicates and sort? Thus we can support (at 
least some of) the user's crazy resolutions and guarantee that he sees, at a 
minimum, a list of standard resolutions.

That's what I already proposed, a long time ago, iirc ;-) Perhaps you now better
understand why, so let's go !

your wisdom is infinite and prescient, I should pay better attention :)

Since we detect full screen resolutions already, I suggest that we limit the
hard-coded listed windowed resolutions to 'supported' 4:3 ratios: 600x480 (vga),
800x600 (svga), 1024x768 (xga), 1280x960, 1400x1050 (sxga+)

It would be nice to put the discussion of how to get xinerama to work in the
README (my old feature request about this died with the tracker) I have
different monitor setup now, but at the time it was quite annoying to have the
game centered on the break in the two monitors.

Likewise the help text when -r99 is used needs to be updated.

Oh yeah, the help text in the README also needs to be updated.

fixed here
http://rb.freedroid.org/r/1365/

Fixed in r4918. Thanks!