Bryan, I am not sure you fully understand fluzz (and I) objection.
The issue is that a user wants to be presented a list of resolutions to use. No
matter whether using windowed or fullscreen mode, you never want to manually
input your resolution. As a result, I understand the underlying motivation for
your original patch (which prompted me to accept it), but I don't think it fits
the functional requirement of a resolution menu.
It's not about maintenance, and a revert in this case has nothing to do with
your patch being well done or not - it's just that on a functional point of view
it turns out that what your patch does is perhaps not what we really want to do
with the resolution menu.
Your thoughts are more than welcome on the matter. |