Issue404

Title Improve issue-updated mails
Priority critical Status resolved
Assigned To matthiaskrgr Keywords
Linked issues Watchers matthiaskrgr

Submitted on 2011-07-25 12h15 by matthiaskrgr, last changed by matthiaskrgr.

Files
File name Uploaded Type Edit Remove
mail.png matthiaskrgr, 2011-07-25.12:15:48 image/png
Messages
Author: matthiaskrgr Date: 2011-07-25   12h15
I think that when I update an issue and get a mail for the update, this mail are
actually one mail for every update the issue had.

Means that I do one change and get {number of updates} +1 mails for this single
change.

See the latest mail and the selected one.

Attached is a screenshot of thunderbird showing this

Attached mail.png.
Author: ahuillet Date: 2011-07-25   16h02
I do not think this is the case. Are you receiving two mails for this very
comment I am writing?
Author: ahuillet Date: 2011-07-25   16h15
On Mon, 25 Jul 2011 16:02:05 +0000
FreedroidRPG bug tracker updates <freedroid-bugs@lists.sourceforge.net> wrote:

> I do not think this is the case. Are you receiving two mails for this very
> comment I am writing?

Problem confirmed, apparently.
Author: ahuillet Date: 2011-07-25   16h18
Raising prio, this is the biggest pain point with the tracker at the moment!
Author: ahuillet Date: 2011-07-25   17h15
This is a check that my understanding of the current situation is correct.

detectors/nosynew.py does:

 # send a copy to the nosy list
        for msgid in cl.get(nodeid, 'messages'):
                try:
                        # note: last arg must be a list
                        cl.send_message(nodeid, msgid, change_note,
['freedroid-bugsATlists.sourceforge.net'], 'bugsATfreedroid.org')
                except roundupdb.MessageSendError, message:
                        raise roundupdb.DetectorError, message


Which seems to send one mail per message in the thread, which isn't what we want.
Author: ahuillet Date: 2011-07-25   19h40
Testing my changes
Author: ahuillet Date: 2011-07-25   19h53
Fixed by only sending updates for the last message in the list. Let's hope that
it's correct. :)
Author: ahuillet Date: 2011-07-25   20h02
Remaining problem: changing the status of a ticket without adding a comment
makes the mail contain the latest comment from the thread, even if it wasn't
added by the change.
Author: ahuillet Date: 2011-07-25   20h52
Testing e-mail updates again
Author: ahuillet Date: 2011-07-25   21h09
Situation was improved by modifying the original nosy reactor.

We now send updates to the nosy list *and* CC -bugs ML.
We also send update messages for tickets when no comment was added, only a
property change.
The only remaining question is whether being assigned a ticket should add
oneself to the nosy list automatically (current behavior).
Author: ahuillet Date: 2011-07-25   21h26
Everything should be in order now. Please reopen if not.
Author: matthiaskrgr Date: 2012-12-23   17h40
test
Author: matthiaskrgr Date: 2012-12-24   00h58
another test
History
Date User Action Args
2012-12-24 00:58:06matthiaskrgrsetmessages: + msg2386
2012-12-23 17:40:56matthiaskrgrsetmessages: + msg2385
2011-07-25 21:26:44ahuilletsetstatus: open -> resolved
assignedto: ahuillet -> matthiaskrgr
messages: + msg1288
nosy: + matthiaskrgr
2011-07-25 21:09:14ahuilletsetmessages: + msg1285
2011-07-25 20:54:53ahuilletsetpriority: important -> critical
2011-07-25 20:52:26ahuilletsetmessages: + msg1282
2011-07-25 20:42:57ahuilletsetpriority: critical -> important
2011-07-25 20:02:21ahuilletsetnosy: - ahuillet
2011-07-25 20:02:18ahuilletsetstatus: resolved -> open
messages: + msg1277
title: entire issue tree resent on update? -> Improve issue-updated mails
2011-07-25 19:53:48ahuilletsetstatus: open -> resolved
messages: + msg1275
2011-07-25 19:44:28ahuilletsetassignedto: ahuillet
nosy: + ahuillet
2011-07-25 19:40:33ahuilletsetmessages: + msg1274
2011-07-25 17:15:16ahuilletsetmessages: + msg1272
2011-07-25 16:18:28ahuilletsetpriority: important -> critical
messages: + msg1270
2011-07-25 16:15:03ahuilletsetmessages: + msg1268
2011-07-25 16:02:05ahuilletsetmessages: + msg1265
2011-07-25 12:15:48matthiaskrgrcreate