Issue830

Title lua.c build failure on OpenBSD
Priority bug Status rejected
Assigned To Keywords
Linked issues Watchers

Submitted on 2015-08-20 08h38 by anjbe, last changed by fluzz.

Files
File name Uploaded Type Edit Remove
typescript anjbe, 2015-08-20.08:38:35 application/octet-stream
Messages
Author: anjbe Date: 2015-08-20   08h38
lua.c: In function 'pop_results':
lua.c:1500: warning: implicit declaration of function 'lua_rawlen'

Among other errors (full log attached).

This is using the same build configuration as 0.15.1.

Attached typescript.
Author: fluzz Date: 2015-08-20   10h44
Mhhh... Something is wrong in the way we detect the lua version available on
your system.
You have Lua5.1, we need Lua5.2.
The configure script should have find that you do not have the right version,
and automatically use the embedded lua sources instead of using the system-wide
version.

What is the output of 'pkg-config --modversion lua' ?

Until we find a fix, you can force the use of the embedded version with
'./configure --with-embedded-lua'

Thx for testing.
Author: anjbe Date: 2015-08-21   03h00
Ah. I was updating the OpenBSD package, which specifies LUA_CFLAGS and LUA_LIBS
manually, which is why the checks didn't trigger.

Using Lua 5.2 fixes the problem.

Some other changes of note... GNU Make is now required and wasn't before
(${shell foo}, export, and define are not portable Make).

Do the localization scripts really need GNU awk specifically? Can they get by
with One True awk?
Author: fluzz Date: 2015-08-21   07h57
> Do the localization scripts really need GNU awk specifically? 
> Can they get by with One True awk?

Well, only one script actually needs gawk. I will try to rewrite it to be
standard awk compatible.
Author: fluzz Date: 2015-08-28   11h57
2 gawk specific features are used: multi-dimensional arrays and sort() function.

The use of multi-dimensional arrays can be avoided.
However, I do not really want to code a sort in awk.

That script is actually only needed during dev (it re-generates the POTFILES.in
files), not when building from the tarball.

So, I will rather remove the call to that script when building from a tarball.


As for the need for gmake. Well, I hope that it's not an issue on OpenBSD. I
definitely would not like to rewrite those Makefiles... Too much work.
Author: digifuzzy Date: 2015-09-01   20h35
@anjbe - the Freedroid BSD port uses gmake.
gmake is also a requirement for MacOSX users with MacPorts.
Author: fluzz Date: 2015-09-01   21h04
Well, before to change several things, I really need to know how annoying it is
to depend on gawk on OpenBSD... Can you please tell me ?
Author: fluzz Date: 2015-11-01   17h18
No reply since 2 months. So, I reject-close the ticket.
Please reopen it if depending on gawk is really annoying on OpenBSD.
History
Date User Action Args
2015-11-01 17:18:15fluzzsetstatus: open -> rejected
priority: 0.16 rc bugs -> bug
messages: + msg3271
2015-09-01 21:04:55fluzzsetmessages: + msg3233
2015-09-01 20:35:22digifuzzysetmessages: + msg3229
2015-08-28 11:57:29fluzzsetmessages: + msg3225
2015-08-21 07:57:06fluzzsetmessages: + msg3221
2015-08-21 03:00:08anjbesetmessages: + msg3220
2015-08-20 10:44:25fluzzsetmessages: + msg3219
2015-08-20 08:38:36anjbecreate